[Nexus] More NAPI stuff

Tobias Richter Tobias.Richter at esss.se
Mon Aug 17 15:23:45 BST 2015


> On 17 Aug 2015, at 15:42, Koennecke Mark (PSI) <mark.koennecke at psi.ch> wrote:
>> I have already recognized this WITH_XXX stuff. There is a bit chaos
>> concerning the configuration headers. Sometimes the code uses nxconfig.h
>> and on other places napiconfig.h. I'am not really sure if this has
>> historical reasons or if this is done intentionally.
>> In the former case I would suggest to clean this up and go for a single
>> configuration header.
>> 
> 
> I think that this is historical. I never dealt with those config.h files, they came with whatever 
> build system we are using. I think cleaning this up is the right solution. Or do you object, Freddie?

Well, apparently nxconfig.h is generated from scratch by autotools and napiconfig.h includes nxconfig.h plus stdint and inttypes, if available as determined by the nxconfig.h defines. (It also does some VMS and Windows magic that I am not interested in.) But napiconfig.h is the fronted file to look at.

That looks like a reasonable thing to do in the autotools world. I cannot see nxconfig.h included directly anywhere, but is (correctly) mentioned in Makefiles as a dependency.

If there is a way to combine those files (napiconfig.h and nxconfig.h) with cmake, that obviously makes things simpler, though. Go for it.

Tobias


More information about the NeXus mailing list