[NeXus-committee] NIAC: seven online votes!

[Aaron Brewster]

Hi all, one week to go!  Here is the status:

   - 11 votes + non-blocking discussion that I've requested to move to a
   new issue
   - 8 votes + reviews + comments that should be addressed
   - 11 votes + discussion that I've commented on
   - 11 votes + reviews + comments that should be addressed
   - 9 votes
   - 10 votes + discussion
   - 9 votes + discussion

So, none of them are passing, and #1408 and #1507 are in an interesting
position.  Paul has suggested comments that Lukas has agreed would be
helpful, but they weren't part of the PR at the time the vote started.  We
don't have a clear policy here.

There are three kinds of comments.  1) Those that are obvious and should
just be fixed.  Things like typos or easy fixes that wouldn't affect
anyone's vote by any rational measure.  2) Those that are substantial
enough that they should probably be addressed after the vote, but shouldn't
really affect people's votes.  3) Dealbreakers that cause a no vote.

My suggestion for Lukas:  for 1) just do the fix and for 3) keep the
comments unresolved for more discussion.  For 2) we can follow this
procedure:

   - Start a new PR that is based on the existing PR branch, addressing
   those comments
   - Resolve a comment at the bottom of the original PR noting the new PR
   - Resolve the comments in the original PR the new PR will address

Any objections from the committee?
Thanks,
-Aaron

On Mon, Jan 27, 2025 at 3:00 PM Aaron Brewster <asbrewster at lbl.gov> wrote:

> Hi all, we have a bumper crop of votes that were started by today's Telco!
> Please vote on the below PRs using emojis on the comments I linked to
> below. 👍 for yes, 👎 for no, anything else (for example 👀) to abstain.
> We need 14 votes to hit quorum so please review and vote! Voting will
> close in two weeks.
>
>    - Allow for open enumerations #1521
>    <https://github.com/nexusformat/definitions/pull/1521#issuecomment-2617047160>
>    - Fairmat 2024: additions and clarifications in NXbeam #1408
>    <https://github.com/nexusformat/definitions/pull/1408#issuecomment-2617049939>
>    - NXcomponent as a parent base class #1525
>    <https://github.com/nexusformat/definitions/pull/1525#issuecomment-2617052302>
>    - Implement-NXobject-inheritance #1507
>    <https://github.com/nexusformat/definitions/pull/1507#issuecomment-2617055267>
>    - Move NXlens_em to base classes #1519
>    <https://github.com/nexusformat/definitions/pull/1519#issuecomment-2617058029>
>    - Fairmat 2024: several new base classes in NXsample and
>    NXsample_component #1413
>    <https://github.com/nexusformat/definitions/pull/1413#issuecomment-2617062395>
>    - [resubmission] move NXpid_controller to base_classes #1528
>    <https://github.com/nexusformat/definitions/pull/1528#issuecomment-2617066301>
>
> Note as we saw in #1408, a vote can fail due to more discussion and that's
> ok, so if you've missed some recent Telcos it's fine to jump in!
>
> Thanks!
> -Aaron
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.nexusformat.org/pipermail/nexus-committee/attachments/20250203/72340c35/attachment.htm>