[Nexus] More NAPI stuff

Koennecke Mark (PSI) mark.koennecke at psi.ch
Mon Aug 17 14:42:59 BST 2015


Eugen,

> Am 17.08.2015 um 15:37 schrieb Eugen Wintersberger <eugen.wintersberger at desy.de>:
> 
> Hi Mark,
> 
> On 08/17/15 14:40, Koennecke Mark (PSI) wrote:
> 
>> 
>> 
>> The C language test fails for two reasons:
>> * It derives the file format to test from the executable name, defaulting to HDF4. A dubious concept, I know. 
>>  I now pushed back modification where it tries to run the HDF5 test with Eugens choosen name for the test program,
> 
> Ok - I got that.
> 
>> * The next thing is that it refuses to run any test. This is because an entry in nxconfig.h or a compile time flag is 
>>  missing. The napi expects at compile time to have WITH_HDF5, WITH_HDF4, WITH_XML defined in 
>> order to conditionally include the necessary code. I do not know enough about cmake to know where to fix this.
> 
> I have already recognized this WITH_XXX stuff. There is a bit chaos
> concerning the configuration headers. Sometimes the code uses nxconfig.h
> and on other places napiconfig.h. I'am not really sure if this has
> historical reasons or if this is done intentionally.
> In the former case I would suggest to clean this up and go for a single
> configuration header.
> 

I think that this is historical. I never dealt with those config.h files, they came with whatever 
build system we are using. I think cleaning this up is the right solution. Or do you object, Freddie?

Regards,

     Mark


> regards
>  Eugen
> 
>> 
>> Regards,
>> 
>>     Mark
>> 
>> 
>> 
>>> regards
>>> Eugen
>>> 
>>> _______________________________________________
>>> NeXus mailing list
>>> NeXus at nexusformat.org
>>> http://lists.nexusformat.org/mailman/listinfo/nexus
>> 
>> 
>> _______________________________________________
>> NeXus mailing list
>> NeXus at nexusformat.org
>> http://lists.nexusformat.org/mailman/listinfo/nexus
>> 
> 
> -- 
> ------------------------------------
> DI. Dr. Eugen Wintersberger
> 
> FS-EC
> DESY
> Notkestrasse 85
> D-22607 Hamburg
> Germany
> 
> E-Mail: eugen.wintersberger at desy.de
> Telefon: +49-40-8998-1917
> -----------------------------------
> 
> _______________________________________________
> NeXus mailing list
> NeXus at nexusformat.org
> http://lists.nexusformat.org/mailman/listinfo/nexus




More information about the NeXus mailing list